Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: validate "contribution checks" wf by introducing extra errors #155

Closed
wants to merge 5 commits into from
Closed

chore: validate "contribution checks" wf by introducing extra errors #155

wants to merge 5 commits into from

Conversation

redfish4ktc
Copy link
Contributor

@redfish4ktc redfish4ktc commented Apr 15, 2024 •
edited by tbouffard
Loading

@tbouffard tbouffard mentioned this pull request Apr 15, 2024
Merged
@tbouffard
Copy link
Member

⚠️ As mentioned in #153 (comment), the "contribution checks" workflow doesn't detect the error because it is checking the commit of the base branch instead of the commit of the PR branch!

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 15, 2024 •
edited
Loading

Contribution Guidelines checks

The content of the files modified by this Pull Request doesn't match the Contribution Guidelines.

Please update the following files.

⏸️ Attributes validation

Some attributes are missing in the following files:

  • :description: are missing in modules/bici/pages/overview.adoc

⛔ Forbidden pattern validation

Some patterns are forbidden in the following files:

This was referenced Apr 16, 2024
Closed
Merged
benjaminParisel pushed a commit to bonitasoft/actions that referenced this pull request Apr 16, 2024
@tbouffard
feat: better support pull_request_target in "antora checker" action (#…
73bef82 
…129)

Ensure that the commit of the PR branch is used when the action is
triggered by `pull_request_target` and not the commit of the base
branch.
Improve debug logs and remove duplication.

### Notes

This should fix what is described in
bonitasoft/bonita-labs-doc#153 (comment).
This PR has been tested with
bonitasoft/bonita-labs-doc#155
Covers
bonitasoft/bonita-documentation-site#685
@tbouffard
Copy link
Member

ℹ️ After the merge of #158, we see that the reusable workflow is using the "antora action" with better support for "pull_request_target" events.
Download action repository 'bonitasoft/actions@v3' (SHA:73bef823d9fc2f37debb73dfd0676cf47ea4c7c4) which is the commit of https://github.com/bonitasoft/actions/tree/v3.1.0

@tbouffard
Copy link
Member

"Contribution Checks" correctly detects all errors in 0a9ec57 and correctly create/update the PR comments.

image

@tbouffard
Copy link
Member

All tests have been successfully completed. So closing this PR.

@tbouffard tbouffard closed this Apr 16, 2024
@redfish4ktc redfish4ktc deleted the redfish4ktc-patch-1 branch April 16, 2024 09:20
@tbouffard tbouffard mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
WIP ☢️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redfish4ktc @tbouffard